v5: Drop node-sass, start reworking build and lint config #1050
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
color contrast functions need some thought - loop issue if we try to use them in settings - may have to move contrast checks into components
Mark some items as todo, turn off rfs for now to make diffs a little easier
Changed `.embed-fluid` to use `aspect-ratio` rule - still need to update docs
Allows us to remove the looktup table with math.pow() in Dart Sass
More moving away from grunt. Drop the dart-sass one as it is the default now. Stub out use of rollup and terser for the JS - still concatenating the files for now.
Will this work?
Double dash?
Strange, since this works on a real browser locally.
Edge >=v120 has some issues with focus/focusin when running onm Sauce - test pass when run locally on Edge v126 Still need to loop back around for iOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.