Skip to content

V5 sass #978

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mbrambilla wants to merge 5 commits into
base: v5-dev-old
Choose a base branch
from
Open

V5 sass #978

mbrambilla wants to merge 5 commits into from

Conversation

@mbrambilla
Copy link
Contributor

@mbrambilla mbrambilla commented Mar 31, 2023

Kind of a first pass, but it is working.

  • Switched from outgoing import to using the use and forward rules
  • Had to break out some settings into new files, and consolidate the $enable-* into the _settings-options.scss file deal with loop. May want to revisit this.

Other items needed:

  • Updated GitHub Actions to remove the CSS (dart-sass) action
  • Update docs sass

@mbrambilla
Update to sass, drop node-sass support
2ee5d6c 
Kind of a first pass, but it is working.

- Switched from outgoing @import to using the @use and @forward
- Had to break out some settings into new files, and consolidate the `$enable-*` into the `_settings-options.scss` file deal with loop.  May want to revisit this.
@mbrambilla
Update lock file
1f604ab
@mbrambilla
Copy link
Contributor Author

mbrambilla commented Jun 13, 2023

Probably going to table this for now. Does not work for external settings overrides.

I am sure there is a way, but this does not appear to be it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

css v5

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@mbrambilla