CID-86 - Record parameters used to install component #116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oanatmaria
reviewed
Jan 16, 2026
oanatmaria
reviewed
Jan 16, 2026
| }, | ||
| Config: map[string]interface{}{}, | ||
| }, nil).Times(2) | ||
| }, nil).AnyTimes() |
Contributor
There was a problem hiding this comment.
Any reason why we can't adjust those to the expected number of calls instead of any ?
oanatmaria
reviewed
Jan 16, 2026
| return extractOperatorParams(ctx, log, k8sClient, namespace) | ||
| case components.ComponentNameSpotHandler: | ||
| return extractSpotHandlerParams(helmRelease) | ||
| case components.ComponentNameClusterController: |
Contributor
There was a problem hiding this comment.
we don't need anything from the agent?
oanatmaria
approved these changes
Jan 16, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When calling
RecordActionResults, we send the component parameters used for installing the component.We send only defined parameters in extractor package.
To handle the case when the operator is upgraded directly with Helm (no with component_action from castware service) a detection of version change, and then new params are recorded.
Values sent for operator with extended-permissions:
