feat: Add BER/FER benchmark for nrLDPCDecode#77
Open
AlonNaor22 wants to merge 2 commits intocatkira:masterfrom
Open
feat: Add BER/FER benchmark for nrLDPCDecode#77AlonNaor22 wants to merge 2 commits intocatkira:masterfrom
AlonNaor22 wants to merge 2 commits intocatkira:masterfrom
Conversation
Full pipeline test: nrLDPCEncode -> nrSymbolModulate (QPSK) -> AWGN channel -> nrSymbolDemodulate (QPSK) -> nrLDPCDecode, measuring bit error rate and frame error rate across SNR points. Closes catkira#50 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
|
nice work, can u also generate a BER plot put it in a docs folder and reference it in README.md? |
Author
|
Sure i will get on it later today
בתאריך יום ו׳, 6 בפבר׳ 2026, 5:48 PM, מאת Benjamin Menküc <
***@***.***>:
… *catkira* left a comment (catkira/py3gpp#77)
<#77 (comment)>
nice work, can u also generate a BER plot put it in a docs folder and
reference it in README.md?
—
Reply to this email directly, view it on GitHub
<#77 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A6CXKSGCZJKLS5N4BVKHUJL4KSZVVAVCNFSM6AAAAACUHXFRGKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZTQNRRGE2DSMRZGU>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Owner
|
or ur agent :) |
Author
|
i mean in this day and age is feels wrong to ignore this |
Owner
|
I agree, I use it a lot myself |
Add plot generation script and resulting PNG showing the classic LDPC waterfall curve. Reference the plot in README.md so it is visible on the project landing page. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
nrLDPCDecode__main__sweeps Eb/N0 from -1 to 5 dB and prints a BER/FER table showing the expected LDPC waterfall curveExample output
Files changed
tests/test_nrLDPCDecode_BER.py(new)Test plan
pytest tests/test_nrLDPCDecode_BER.pypasses (1 passed in 4.6s)Closes #50
🤖 Generated with Claude Code