Skip to content

Conversation

@disordered
Copy link
Contributor

This improves legibility of background colors for file scopes in editor tabs and file explorer. Also adds new pre-defined "Grey" color for file scopes.

For reference, this is how IntelliJ Light and Dark themes look:
ij-dark
ij-light

This is how it looks like in 3.5.2 version of the theme:
Latte:
latte-3 5 2
Frappe:
frappe-3 5 2
Macchiatto:
macchiato-3 5 2
Mocha:
mocha-3 5 2

And this is after the changes:
Latte:
latte-fixed
Frappe:
frappe-fixed
Macchiatto:
macchiato-fixed
Mocha:
mocha-fixed

Closes #237


{%- macro file_color(color) -%}
{{ color | mix(color=base, amount=0.05) | get(key='hex') }}
{%- set mix_amount = if(cond = flavor.light, t = 0.15, f = 0.25) -%}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dark flavors could probably work under 0.15 opacity too, but I couldn't figure out how to reduce that yellow tint that is applied to unselected editor tabs. I tried changing EditorTabs -> unselectedBlend, but it didn't really help.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Figured out that I can replace yellow tint with opacity instead via inactiveColoredFileBackground.

So, removed conditional opacity on file colors and added 50% opacity reduction on inactive colored tabs. Active ones show the same color as defined for that scope.
After these changes it now looks like this:
Latte:
latte-fixed-2
Frappe:
frappe-fixed-2
Macchiatto:
macchiatto-fixed-2
Mocha:
mocha-fixed-2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Proposal to increase contrast between FileColors (scopes) and UI background colour

1 participant