Skip to content

fix: semibold keywords for latte #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
sgoudham merged 5 commits into from
Jul 31, 2025
Merged

fix: semibold keywords for latte #17

sgoudham merged 5 commits into from
Jul 31, 2025
+2 −2

Conversation

@lilidotshi
Copy link
Contributor

@lilidotshi lilidotshi commented Jul 28, 2025 •
edited
Loading

The default/classic light theme in Xcode uses semibold for keywords. This PR updates such that Latte now matches that weight.

Issue: #15

@lilidotshi
Copy link
Contributor Author

lilidotshi commented Jul 29, 2025

@sgoudham thoughts?

@lilidotshi lilidotshi marked this pull request as draft July 29, 2025 19:15
@lilidotshi lilidotshi marked this pull request as ready for review July 29, 2025 19:35
@uncenter
Copy link
Member

uncenter commented Jul 30, 2025

Why is this latte only?

(Also, nit: this should be a fix:/feat:, refactor:s don't change theme behavior).

@lilidotshi
Copy link
Contributor Author

lilidotshi commented Jul 30, 2025

Why is this latte only?

(Also, nit: this should be a fix:/feat:, refactor:s don't change theme behavior).

From what I can tell, Latte is the only "light" mode theme so this follows Xcode's default theme patterns of Light -> Semibold, Dark -> Bold

@lilidotshi lilidotshi changed the title refactor: update keyword font weight for Latte fix: update keyword font weight for Latte Jul 30, 2025
@uncenter
Copy link
Member

uncenter commented Jul 30, 2025

Ah okay. Maybe fix: semibold keywords for latte?

@lilidotshi
Copy link
Contributor Author

lilidotshi commented Jul 30, 2025

Ah okay. Maybe fix: semibold keywords for latte?

Done

@lilidotshi lilidotshi changed the title fix: update keyword font weight for Latte fix: semibold keywords for latte Jul 30, 2025
uncenter
uncenter reviewed Jul 30, 2025
View reviewed changes
lilidotshi and others added 2 commits July 30, 2025 10:06
@lilidotshi @uncenter
Update xcode.tera
6a2c4a6 
Co-authored-by: uncenter <uncenter@uncenter.dev>
@lilidotshi
Update xcode.tera
194a5b1
@lilidotshi
Copy link
Contributor Author

lilidotshi commented Jul 30, 2025

(how do i merge this)

@sgoudham sgoudham linked an issue Jul 31, 2025 that may be closed by this pull request
Keywords are too bold #15
Closed
sgoudham
sgoudham approved these changes Jul 31, 2025
View reviewed changes
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pretty odd default behaviour (and I don't like that we're setting the font in the first place, but I assume it's required)

Thanks for aligning it with their defaults!

Something to explore, can we leave it out and will it default anyways?

@sgoudham sgoudham merged commit 4b1228c into catppuccin:main Jul 31, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sgoudham sgoudham sgoudham approved these changes

+1 more reviewer

@uncenter uncenter uncenter approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Keywords are too bold

3 participants

@lilidotshi @uncenter @sgoudham