Open
Conversation
jgiven100
approved these changes
Nov 27, 2020
Contributor
jgiven100
left a comment
jgiven100
left a comment
There was a problem hiding this comment.
Minor nitpick, otherwise I'm ok
user/preprocess/input.md
Outdated
|  | ||
|
|
||
| ### ASCII Math Functions | ||
| Math functions can also be specified through an ASCII file, and this is useful when it is rather long such that can be used to define time history of a dynamic earthquake ground motion. The JSON configuration for the math function is: |
Contributor
There was a problem hiding this comment.
Suggested change
| Math functions can also be specified through an ASCII file, and this is useful when it is rather long such that can be used to define time history of a dynamic earthquake ground motion. The JSON configuration for the math function is: | |
| Math functions can also be specified through an ASCII file, and this is useful when they are rather long such as math functions used to define time history of a dynamic earthquake ground motion. The JSON configuration for the math function is: |
kks32
requested changes
Nov 30, 2020
user/preprocess/input.md
Outdated
| "id": 1, | ||
| "type": "Linear", | ||
| "file": "math-function.txt", | ||
| "xvalues": [], |
Contributor
There was a problem hiding this comment.
If you are setting a file, you shouldn't need x and fx values
user/preprocess/input.md
Outdated
| Math function can be specified in the following format: | ||
|
|
||
| ``` | ||
| x_0 fx_0 |
Contributor
There was a problem hiding this comment.
Can we go csv instead of tab separated?
Contributor
Author
There was a problem hiding this comment.
Will do so. Will change the main PR first
kks32
requested changes
Dec 6, 2020
| { | ||
| "id": 1, | ||
| "type": "Linear", | ||
| "file": "math-function.csv" |
Contributor
There was a problem hiding this comment.
There is inconsistency in naming, here it's called file and above csvfile, please use file
| Math function can be specified in the following format: | ||
|
|
||
| ``` | ||
| x_0, fx_0, |
Contributor
There was a problem hiding this comment.
If you are using a csv parser, could we have a header line?
Contributor
Author
|
@kks32, do you still have more comments on this? |
Contributor
|
Blocked by: cb-geo/mpm#701 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for cb-geo/mpm#701
HTML can be seen here: https://ezrayst.github.io/mpm-doc/#/