code doctor test #55
Open
code doctor test #55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feature/#64 split purchase by weights
![code-review-doctor[bot]](https://avatars.githubusercontent.com/in/83430?s=60&v=4){kind=small}
|
|
||
|
|
||
| class PurchaseWeight(TimestampMixin, models.Model): | ||
| purchase = models.ForeignKey("purchases.Purchase", on_delete=models.CASCADE) |
There was a problem hiding this comment.
Django automatically creates a related_name if it's not set. If it were set then a more readable and explicit relationship is set up. More details.
|
|
||
| class PurchaseWeight(TimestampMixin, models.Model): | ||
| purchase = models.ForeignKey("purchases.Purchase", on_delete=models.CASCADE) | ||
| member = models.ForeignKey("auth.User", on_delete=models.CASCADE) |
There was a problem hiding this comment.
Again, with an explicit related_name would be better.
Makes it easier to e.g. use 3 for everyone except one person.
| user_id = obj["user__id"] | ||
| filepath = os.path.join( | ||
| output_dir, | ||
| "{0}{1}".format(user_id, ext), |
There was a problem hiding this comment.
f-string is easier to read, write, and less computationally expensive than legacy string formatting. Read more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.