Update to Ember CLI 2.8 and fix failing tests in beta and canary #112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BrianSipple
force-pushed
the
update-version-and-fix-tests
branch
from
b228ec2 to
7848583
Compare
cball
approved these changes
Oct 18, 2016
|
|
||
| // this currently includes 1 px border from the appearance css. not ideal. | ||
| assert.equal(this.$('.fixed-table-columns-wrapper').width(), 151); | ||
| assert.equal(parseInt(window.getComputedStyle(columnsElem).width), 151); |
Owner
There was a problem hiding this comment.
👍 on moving to this format. I imagine anywhere we get the width should move to this style, but baby steps. 😄
| */ | ||
| export default function getNode(context = this) { | ||
| return context.$()[0].firstElementChild; | ||
| } |
| let rows = $('.table-columns tr').length; | ||
| let headers = $('.table-columns th').text().trim(); | ||
| let rows = Ember.$('.table-columns tr').length; | ||
| let headers = Ember.$('.table-columns th').text().trim(); |
Owner
There was a problem hiding this comment.
Thoughts on changing import jQuery from 'jquery' above vs updating this to Ember.$? If you're thinking it's more clear that Ember.$ does not reference the window scope, I'm good with that.
Collaborator
Author
There was a problem hiding this comment.
All for it! I'll make that change real quick.
BrianSipple
force-pushed
the
update-version-and-fix-tests
branch
from
7848583 to
dcf282a
Compare
Collaborator
Author
|
@cball just updated and rebase around your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since Ember CLI 2.8 was released, I've noticed that our project (currently on 2.7) has been failing in CI for both "beta" (2.9) and "release" configurations. (Side note:
ember-tryis amazing.)This can be seen across the builds for the last few PRs (see: the four previous builds from this point).
To remedy this, I updated the project to 2.8, ran
ember-initto resolve any discrepancies, and went about fixing things. Outside of some minor syntax changes, the main changes regarding functionality...window.getComputedStylefor element measurement after renderclassNamesSo far, so green. I'll update and rebase #111 and #110 if all goes well here.