Skip to content

Conversation

@artivis
Copy link
Collaborator

@artivis artivis commented Apr 12, 2018

Do not print error message while retrieving a param with default value.

Fix #47 .

Do not print error message while retrieving param with default value.
@artivis artivis self-assigned this Apr 12, 2018
@beetleskin
Copy link

Is this going to be merged and deployed anytime soon?

Btw, I get the error when I try to instantiate the param struct manually:

ros::NodeHandle pnh("~");
my_package::MyNodeParameters params(pnh);
params.fromParamServer();

Is there a better way of doing it, maybe withouth NodeHandle? I just want to get the struct with the default values.

@artivis
Copy link
Collaborator Author

artivis commented Jun 6, 2018

Indeed this has been pending for a while now, my bad.
I'll try to take care of it this weekend 👍.

The current API does not offer the possibility to instantiate the default values without a NodeHandle. However I think this would be fairly doable, again I'll see what I can do over the weekend.

@artivis artivis merged commit 55916be into develop Jun 9, 2018
@artivis artivis deleted the fix/47-1 branch June 9, 2018 08:02
@artivis
Copy link
Collaborator Author

artivis commented Jun 9, 2018

@beetleskin FYI I will wait some more changes before releasing again (hopefully #37) as the issue this PR fixes is annoying but not critical.

Notice that #37 also initializes parameters with default value at construction time cutting the need from calling params.fromParamServer() to use them :

my_package::MyNodeParameters params(ros::NodeHandle("~"));
my_var_with_default = params.my_var_with_default;

I'll evaluate later the need & implications of a NodeHandle-free constructor...

@beetleskin
Copy link

seems legit, thanks!

@beetleskin
Copy link

any release date in sight here? :)

@beetleskin
Copy link

.. not?

@artivis
Copy link
Collaborator Author

artivis commented Aug 17, 2018

Hi there,
I'm currently on vacation. Ill take care of releasing it in a couple weeks, after merging #56.
Sorry for the late answer / delay.

@artivis
Copy link
Collaborator Author

artivis commented Sep 3, 2018

@beetleskin FYI release 0.1.4 is on the way for Indigo/Kinetic & Lunar 👍.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants