bug fix #4
Open
bug fix #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Indeed, the client did not respond in any way after being notified of the server disconnection, which can be resolved by applying this fix. |
Owner
|
thanks @amdfxlucas @nmgwddj. i haven't been working on this library, but i'm happy to merge under the conditions that you:
|
Owner
|
i'm happy to review additional changes, but please open a separate pull request for each feature, with commit messages that describe the changes and their motivation |
Author
|
oops, pushed to wrong branch. Didnt want those commits to show up here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
connection_state::open::incoming_streams was uninitialized
( connection erroneously couldnt accept streams because circular buffer wrongly deemed full (capacity zero) )
reading from stream never returned EOF after peer shutdown its end for write