fix: include agent install data in recipe hash #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
computeRecipeHash did not account for agent install scripts or credential directories, so changes to the agent registry (new agents, updated install URLs) were invisible to IsStale and the cached image was silently reused. Add agent name, install script, and credentials directory to the hash so that agent changes trigger an image rebuild.
Contributor
There was a problem hiding this comment.
Pull request overview
Updates container image staleness detection so cached images are invalidated when the set of registered agents (and their install metadata) changes, preventing reuse of images with outdated agent installs.
Changes:
- Include agent registry install metadata (name, install script, credentials dir) in
computeRecipeHash. - Add a unit test asserting agent registration changes the recipe hash.
- Add a plan/todo note documenting the bug and verification steps.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
internal/container/image.go |
Extends computeRecipeHash to hash agent install inputs for staleness detection. |
internal/container/image_name_test.go |
Adds TestComputeRecipeHash coverage to ensure agent registry changes affect the hash. |
docs/plans/todo/fix-recipe-hash-missing-agent-data.md |
Documents the issue, intended fix, and verification steps. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
computeRecipeHashso agent changes mark cached images staleTestComputeRecipeHashcoverage to verify agent registration changes the recipe hashValidation
go test ./...make lintgo test ./internal/container -run 'TestComputeRecipeHash|TestIsStale' -count=1