🧹 chore: remove leftover debug print in fields.py#217
Conversation
Removed the `print(e)` statement in `src/scida/fields.py` and replaced it with `log.debug(e)` to use the module-level logger. Also updated the `ValueError` to use exception chaining with `from e`. Co-authored-by: cbyrohl <9221545+cbyrohl@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Remove log.debug(e) which is redundant now that 'from e' chains the original exception - Fix adjacent logging.warning() to use module-level log.warning() for consistency with the rest of the codebase Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
🎯 What: Removed a leftover debug
print(e)insrc/scida/fields.pyat line 724.💡 Why: Printing to stdout in library code is discouraged. Replacing it with
log.debugand usingfrom ein the subsequentraise ValueErrorimproves maintainability and traceability of exceptions.✅ Verification: Manual code review and linting with
ruff.✨ Result: Cleaner library code that follows best practices for logging and exception handling.
PR created automatically by Jules for task 5594832916555932427 started by @cbyrohl