🧪 Add unit tests for get_container_from_path#218
Conversation
Added TestGetContainerFromPath to tests/unit/test_misc.py to cover: - Nested container retrieval (happy path) - Path normalization (handling of leading, trailing, and multiple slashes) - Dynamic container creation with create_missing=True - Error handling when containers are missing and create_missing=False Verified the logic with a mocked environment. Co-authored-by: cbyrohl <9221545+cbyrohl@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Remove brittle _containers assertions in test_create_missing; the identity check already proves the full path was created. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
This PR adds comprehensive unit tests for the
get_container_from_pathutility function insrc/scida/misc.py.The new tests cover:
FieldContainerstructures.create_missingfunctionality for auto-generating missing hierarchy levels.PR created automatically by Jules for task 34040221436878406 started by @cbyrohl