Save units in metadata during Zarr export#220
Conversation
Modified `BaseDataset.save` to collect unit strings from fields before stripping them from the data arrays. These units are then saved as a 'units' attribute in the Zarr metadata after the data is written. Updated `get_unitstr_from_attrs` in `UnitMixin` to recognize this new 'units' attribute during dataset loading, ensuring better round-trip support for unit-aware data in Zarr format. Co-authored-by: cbyrohl <9221545+cbyrohl@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Remove redundant hasattr(arr, "units") inside hasattr(arr, "magnitude") since every pint.Quantity always has both attributes - Add integration test verifying unit strings are correctly written to zarr metadata attributes during save Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
1 participant
The
savemethod inscida/interface.pywas stripping units from dask arrays without persisting them in the Zarr metadata. This PR implements unit preservation by:saveloop.unitsattribute of the corresponding Zarr datasets after computation.scida/interfaces/mixins/units.pyto read from theunitsattribute when available.Verified via logic simulation and mock-based testing.
PR created automatically by Jules for task 4072040458856553065 started by @cbyrohl