Add Toast Notification on warnings or errors.#12
Open
kriserickson wants to merge 10 commits intoccampbell:masterfrom
Open
Add Toast Notification on warnings or errors.#12kriserickson wants to merge 10 commits intoccampbell:masterfrom
kriserickson wants to merge 10 commits intoccampbell:masterfrom
Conversation
Merge remote-tracking branch 'upstream/master' Conflicts: log.js options.html
Owner
|
@syabro it looks like some of the code was actually from 11 months ago. I think I updated some of the code formatting since then 😄 I do agree those should be updated. I haven't had time to play around with this PR yet, but hopefully will get to soon. |
Author
|
Apologies if any of the code formatting changed, I tried to change as little as possible however I use WebStorm which auto-formats code on paste's and such and @ccampbell is correct the changes were actually made from the codebase from months ago and I obviously had some merge issues when I merged to the latest code (which is much cleaner BTW). |
added 5 commits
April 23, 2013 07:58
|
To others looking for a solution, this extension should do it for every console error: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I found that some errors and warnings sent to the logger where getting ignored so I added a visible notification of errors and warnings sent from the server.