futures #342
futures #342
Conversation
|
hi, thanks for the work. thanks |
|
I am still editing and adding futures for other functions. I will check out merge conflicts |
php-binance-api.php
Outdated
| * @return array with error message or the order details | ||
| */ | ||
| public function buy(string $symbol, $quantity, $price, string $type = "LIMIT", array $flags = []) | ||
| public function buy(string $symbol, $quantity, $price, string $type = "LIMIT", array $flags = [], $futures = false) |
There was a problem hiding this comment.
I think it would be better to use a new class FAPI or FuturesAPI than to do this with switches. Otherwise, if Margin API is introduced, do you want to be switching Margin and Futures on and off?
php-binance-api.php
Outdated
| public function buy(string $symbol, $quantity, $price, string $type = "LIMIT", array $flags = [], $futures = false) | ||
| { | ||
| return $this->order("BUY", $symbol, $quantity, $price, $type, $flags); | ||
| return $this->order("BUY", $symbol, $quantity, $price, $type, $flags, false, $futures); |
There was a problem hiding this comment.
Or at least use the $flags array to set 'fapi' => true and send it to the third parameter of httpRequest() like it's done with wapi and sapi already.
There was a problem hiding this comment.
I'm more for a separate class or at least separate functions like fBuy and/or fHttpRequest or whatever would fit best. Having the wapi and sapi is according to me already more then enough in httpRequest... (personal view!)
There was a problem hiding this comment.
Yeah, SAPI could be a separate class as well to make it cleaner. WAPI is deprecated as of today: https://www.binance.com/en/support/announcement/f45dde7da58b473aa885349946bed269
|
I added FAPI class where all functions are the same but they are linked to futures endpoints. There is change in userData stream where you can add function which can be runner on connection to the WebSocket. You can review it now |
|
Can you please rebase? |
I haven't used it before. I don't know if that should happen. Command: git rebase |
You need to rebase onto jaggedsoft:master. You're likely doing the default where it's your fork's master. |
|
I rebased. Anything else to do? |
|
Hello @AlexVanchov, Did you implement a getPositions function? I could not find it in changes. |
|
did you push the changes to the merge request.. still tell me here there are maege conflicts This branch cannot be rebased due to conflicts |
|
I would love to see this merge. can you please rebase, squash and push the commits? |
|
It still have some bugs with futures for some functions. I will pull request again when it's ready |
|
any update here? |
5 participants
No description provided.