-
Notifications
You must be signed in to change notification settings - Fork 6
Change to Pyproject.toml installation and uv, remove python 3.8 support, add python 3.13 and 3.14 support #57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@allevitan it looks like we are losing python 3.8 with the latest |
|
@gnzng What do you prefer to do? Drop support for python 3.8 or test with an earlier version of pytorch? |
|
@allevitan I would probably recommend discontinuing support for Python 3.8, as it reached end of life and no longer receives security updates. |
|
Agreed |
allevitan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested installation from source with the new pyproject.toml on my system and went through the files. I just have a few small comments to address before we merge.
allevitan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Commits from this PR were recently discussed in #56:
be28903:
requirements.txtand removes outdatedsetup.py728cf9d: