Package type #130
Open
Package type #130
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rare situations, if you have theme / plugin with same slug, it can cause issue, which is saved / generated later will overwrite the existing package (specially if version is same). So this patch will try to avoid such situations.
on windows / wamp server, this throws the issue if file is downloaded directly from dashboard, so this workaround allows for proper download
lkraav
suggested changes
Jun 22, 2020
lkraav
left a comment
lkraav
left a comment
There was a problem hiding this comment.
Is this going to break all existing installations, as-in require a change their composer.json for new vendor? If yes, it's probably not going to fly. This package type business probably needs to be an opt-in kind of a thing somehow.
src/HTTP/ResponseBody/FileBody.php
Outdated
| * @throws InvalidFileName If the file name fails validation. | ||
| */ | ||
| public function __construct( string $filename ) { | ||
|
|
There was a problem hiding this comment.
We should probably not be changing coding style, remove space-only changes.
src/Release.php
Outdated
| $this->get_package()->get_slug(), | ||
| '/satispress/%s/%s/%s', | ||
| $package_type, | ||
| $this->get_package()->get_slug(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #109