Some adjustments to use behave tests with Podman

[jmtd]

This introduces an environment variable CTF_API_SOCK, defaulting to unix://var/run/docker.sock, to permit a user to point it at another API end-point, such as Podman.

[jmtd]

Hi @rnc, for your consideration :)

[rnc]

Hi @rnc, for your consideration :)

This is very interesting. Does it solve cekit/cekit#495 ? I think there needs to be some documentation or pointers at least for setup? In that issue you mentioned about logging - is that still a problem?

[jmtd]

This is very interesting. Does it solve cekit/cekit#495 ?

I don't think it completely solves it, but it moves us much closer. I think some of the steps may need adjusting to work with both docker and podman.

I think there needs to be some documentation or pointers at least for setup?

Should that go in this repo, or extend the Cekit docs?

In that issue you mentioned about logging - is that still a problem?

I need to try re-running all our image tests with this change and podman to see how they fair.

[rnc]

This is very interesting. Does it solve cekit/cekit#495 ?

I don't think it completely solves it, but it moves us much closer. I think some of the steps may need adjusting to work with both docker and podman.

I think there needs to be some documentation or pointers at least for setup?

Should that go in this repo, or extend the Cekit docs?

Well the only docs in this repo is what you just did in #78 so I think perhaps adding to CEKit docs in https://docs.cekit.io/en/latest/handbook/testing/behave.html might be best.

In that issue you mentioned about logging - is that still a problem?

I need to try re-running all our image tests with this change and podman to see how they fair.

Ok cool.

[jmtd]

@jmtd wrote:

I need to try re-running all our image tests with this change and podman to see how they fair.

I did that, good results:

   docker:
     13 features passed, 0 failed, 2 skipped
     44 scenarios passed, 0 failed, 26 skipped
     124 steps passed, 0 failed, 80 skipped, 0 undefined
     Took 19m12.514s

    podman:
     13 features passed, 0 failed, 2 skipped
     44 scenarios passed, 0 failed, 26 skipped
     124 steps passed, 0 failed, 80 skipped, 0 undefined
     Took 19m44.736s

@rnc wrote:

I think perhaps adding to CEKit docs in https://docs.cekit.io/en/latest/handbook/testing/behave.html might be best.

I'll prepare that in another PR. Do you consider that blocking this one?

[jmtd]

I've recently learned/remembered the env var DOCKER_HOST which is honoured by the official Docker client (i.e. /usr/bin/docker) and some API tooling : the python-docker library supports it for the main client API; and it seems s2i also honours that variable.

However, this repo doesn't use the python-docker client API, but the low-level API, which doesn't honour DOCKER_HOST.

I think this PR could be shrunk to only 80519a2 if we used DOCKER_HOST as the name, and bd6f051 would no longer be necessary. I am testing.

[jmtd]

Confirmed with local testing. PR shrunk and improved. I've left in the clean-up 36f8f8b even though it's no longer strictly necessary; I think it aids code clarity.

[jmtd]

Docs: cekit/cekit#943

[jmtd]

Note: it turns out s2i supports unix:///run/user/1000/podman/podman.sock but not the prefixed versions of the URI http+unix:///run/user/1000/podman/podman.sock