Add in-situ cartesian field map construction from Geant4#1828
Add in-situ cartesian field map construction from Geant4#1828esseivaju merged 14 commits intoceleritas-project:developfrom
Conversation
Test summary 4 456 files 6 838 suites 13m 34s ⏱️ Results for commit 1014963. ♻️ This comment has been updated with latest results. |
sethrj
left a comment
There was a problem hiding this comment.
Looks great! This is a nice addition. @rahmans1 @sanmayphy this should be useful in your framework integration.
|
I did not do a thorough job with this review. I know we were in a rush to get this in, but this code is virtually untested. I can't edit any of it for fear of breaking something. Our helper functions are using different units internally. |
|
Did you spot a bug where we have a unit mismatch? I can take a look at adding unit test but since we're getting the field from Geant4, some part would require a mock Geant4 run |
|
Never mind, I am an idiot and it was a problem with my test: I had the wrong units for the scale factor (neglecting a 1/length). |
Implements
CartMapMagneticFieldas aG4MagneticFieldwrapper around CeleritasCartMapField. Includes:CartMapMagneticFieldclass using pimpl to hide C++20 dependenciesMakeCartMapFieldInputfunction to query and build Celeritas field from an existingG4FieldCylMapMagneticFieldto use shared field sampling utilitiescovfiedependency to accel