Fix edge cases with optical setup and runtime#2191
Merged
sethrj merged 3 commits intoceleritas-project:developfrom Jan 13, 2026
Merged
Fix edge cases with optical setup and runtime#2191sethrj merged 3 commits intoceleritas-project:developfrom
sethrj merged 3 commits intoceleritas-project:developfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2191 +/- ##
===========================================
+ Coverage 86.15% 86.27% +0.11%
===========================================
Files 1287 1287
Lines 40709 40709
Branches 12994 12548 -446
===========================================
+ Hits 35074 35122 +48
+ Misses 4624 4414 -210
- Partials 1011 1173 +162
🚀 New features to boost your workflow:
|
Test summary 5 757 files 9 242 suites 17m 50s ⏱️ Results for commit 9ed1cfa. |
Member
Author
|
Shit, I didn't update with #2189 before merging. |
sethrj
added a commit
to sethrj/celeritas
that referenced
this pull request
Jan 13, 2026
* Add high-level optical surface integration test * Allow optical materials to be unused by geometry volumes * Allow zero cross section for vacuum
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a high-level coverage test for optical physics with surfaces, originally targeting #1928 , but using a test input that discovered two edge cases we didn't account for: