Improve testing for field and geo view#2230
Merged
sethrj merged 8 commits intoceleritas-project:developfrom Feb 5, 2026
Merged
Improve testing for field and geo view#2230sethrj merged 8 commits intoceleritas-project:developfrom
sethrj merged 8 commits intoceleritas-project:developfrom
Conversation
- Don't propagate if zero distance for electron_tangent_cross_smallradius - Add try/catch where appropriate - Check for geo failures
sethrj
added
documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #2230 +/- ##
===========================================
+ Coverage 85.27% 86.87% +1.59%
===========================================
Files 1290 1325 +35
Lines 40380 41929 +1549
Branches 10547 13391 +2844
===========================================
+ Hits 34436 36425 +1989
- Misses 4357 4489 +132
+ Partials 1587 1015 -572
🚀 New features to boost your workflow:
|
Test summary 5 852 files 9 390 suites 19m 30s ⏱️ Results for commit c470a22. ♻️ This comment has been updated with latest results. |
mrguilima
reviewed
Feb 5, 2026
Contributor
mrguilima
left a comment
mrguilima
left a comment
There was a problem hiding this comment.
A late comment, just in case...
|
|
||
| if(CELERITAS_USE_VecGeom) | ||
| if(CELERITAS_CORE_GEO STREQUAL "VecGeom" | ||
| AND (CELERITAS_USE_CUDA OR VecGeom_VERSION VERSION_GREATER_EQUAL "2.0")) |
Contributor
There was a problem hiding this comment.
Can't the VG 2.0 solids-based geometry be rebuilt?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves some changes to the base behavior out of #2133 to better illustrate the changes in that PR.