Use unordered containers in DeMorganSimplifier

[esseivaju]

Follow-up to #2231, use map and set instead of pre-allocated vectors.

[codecov]

Codecov Report

❌ Patch coverage is 93.93939% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.82%. Comparing base (43e05ae) to head (092ff67).

Files with missing lines	Patch %	Lines
src/orange/orangeinp/detail/DeMorganSimplifier.cc	93.93%	0 Missing and 2 partials ⚠️

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #2232   +/-   ##
========================================
  Coverage    86.81%   86.82%           
========================================
  Files         1330     1330           
  Lines        42019    42027    +8     
  Branches     12950    12949    -1     
========================================
+ Hits         36480    36489    +9     
  Misses        4335     4335           
+ Partials      1204     1203    -1     

Files with missing lines	Coverage Δ
src/orange/orangeinp/detail/DeMorganSimplifier.hh	100.00% <ø> (ø)
src/orange/orangeinp/detail/DeMorganSimplifier.cc	97.72% <93.93%> (+0.10%)	⬆️

... and 4 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[github-actions]

Test summary

 5 893 files   9 431 suites   18m 27s ⏱️
 2 146 tests  2 118 ✅  28 💤 0 ❌
32 254 runs  32 096 ✅ 158 💤 0 ❌

Results for commit 092ff67.

♻️ This comment has been updated with latest results.

[amandalund]

In the places where we call translation() inside an assertion, is the node always guaranteed to already be in the map, or is it possible for the debug check to create a new entry?

[esseivaju]

Ah thanks good catch! There's no guarantee that the node is present when calling the assertion. I've reworked this to avoid the side-effect in the assertion.