Skip to content

Add MuCF interactor for muonic dd molecules#2236

Merged
sethrj merged 8 commits intoceleritas-project:developfrom
stognini:mucf-dd-interactor
Feb 6, 2026
Merged

Add MuCF interactor for muonic dd molecules#2236
sethrj merged 8 commits intoceleritas-project:developfrom
stognini:mucf-dd-interactor

Conversation

@stognini
Copy link
Member

@stognini stognini commented Feb 6, 2026

This PR implements the muon-catalyzed fusion interactor for $(dd)_\mu$ molecules.

To avoid code duplication, a few utils helper functions are created and shared between both $(dd)_\mu$ and $(dt)_\mu$ interactors and are expected to be used by the last interactor. This is a component of #1508 .

@stognini stognini added enhancement New feature or request physics Particles, processes, and stepping algorithms labels Feb 6, 2026
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

❌ Patch coverage is 98.30508% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.86%. Comparing base (43e05ae) to head (912af6a).
⚠️ Report is 3 commits behind head on develop.

Files with missing lines Patch % Lines
src/celeritas/mucf/interactor/DDMucfInteractor.hh 96.36% 1 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2236      +/-   ##
===========================================
+ Coverage    86.81%   86.86%   +0.05%     
===========================================
  Files         1330     1331       +1     
  Lines        42019    42102      +83     
  Branches     12950    12951       +1     
===========================================
+ Hits         36480    36574      +94     
+ Misses        4335     4319      -16     
- Partials      1204     1209       +5     
Files with missing lines Coverage Δ
src/celeritas/mucf/data/DTMixMucfData.hh 91.66% <ø> (ø)
src/celeritas/mucf/interactor/DTMucfInteractor.hh 93.33% <100.00%> (-1.98%) ⬇️
...itas/mucf/interactor/detail/MucfInteractorUtils.hh 100.00% <100.00%> (ø)
src/celeritas/phys/PDGNumber.hh 96.66% <100.00%> (+7.38%) ⬆️
src/celeritas/mucf/interactor/DDMucfInteractor.hh 95.23% <96.36%> (+95.23%) ⬆️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test summary

 5 913 files   9 451 suites   18m 37s ⏱️
 2 151 tests  2 123 ✅  28 💤 0 ❌
32 338 runs  32 180 ✅ 158 💤 0 ❌

Results for commit 912af6a.

♻️ This comment has been updated with latest results.

@stognini stognini requested a review from sethrj February 6, 2026 15:37
@stognini stognini mentioned this pull request Feb 6, 2026
23 tasks
@sethrj
Copy link
Member

sethrj commented Feb 6, 2026

@stognini build errors indicate you're missing some inline keywords:

multiple definition of `celeritas::detail::calc_third_secondary(celeritas::Secondary, celeritas::Quantity<celeritas::units::MevPerCsq, double>, celeritas::Secondary, celeritas::Quantity<celeritas::units::MevPerCsq, double>, celeritas::OpaqueId<celeritas::Particle_, unsigned int>, celeritas::Quantity<celeritas::units::MevPerCsq, double>)'; src/celeritas/CMakeFiles/celeritas.dir/mucf/model/DTMixMucfModel.cc.o:/__w/celeritas/celeritas/src/celeritas/mucf/interactor/detail/MucfInteractorUtils.hh:114: first defined here

@sethrj sethrj merged commit 599cdbc into celeritas-project:develop Feb 6, 2026
42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request physics Particles, processes, and stepping algorithms

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants