Make proto construction independent of hardcoded runtime tracking#2239
Open
sethrj wants to merge 5 commits intoceleritas-project:developfrom
Open
Make proto construction independent of hardcoded runtime tracking#2239sethrj wants to merge 5 commits intoceleritas-project:developfrom
sethrj wants to merge 5 commits intoceleritas-project:developfrom
Conversation
sethrj
added
enhancement
Test summary 5 913 files 9 451 suites 18m 30s ⏱️ Results for commit 5178fba. ♻️ This comment has been updated with latest results. |
sethrj
force-pushed
the
infix-construction
branch
from
fc3d917 to
812bf8c
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2239 +/- ##
===========================================
- Coverage 86.88% 86.84% -0.05%
===========================================
Files 1331 1331
Lines 42123 42127 +4
Branches 12961 12965 +4
===========================================
- Hits 36600 36585 -15
- Misses 4319 4339 +20
+ Partials 1204 1203 -1
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that #2238 is merged, this follows on to discussions on #1565 and #2121, allowing protos to construct inputs with postfix notation for testing and verification purposes. The 'logic' entry on the unit input now actually reflects the notation representation, rather than whether negated-join elimination took place.
This should also improve setup time: previously, all the inputs had to be re-transformed from postfix to infix notation during OrangeParams construction. Now (by default) they're just built directly as infix.