Import muCF cycle rate data and construct muCF model #2240
Open
stognini wants to merge 38 commits intoceleritas-project:developfrom
Open
Import muCF cycle rate data and construct muCF model #2240stognini wants to merge 38 commits intoceleritas-project:developfrom
stognini wants to merge 38 commits intoceleritas-project:developfrom
Conversation
- Move types to new mucf/Types.hh - Move MucfParticles::from_params to model.cc as a free function - Move all static data to MucfPhysics.cc - Refactor/Remove types in DTMixMucfData - Remove CELER_EXPECT(mu_minus) during MucfProcess construction
- Fix import data - Refactor the material calculator to behave as a material inserter - Interactors: define number of secondaries as EnumArrays - Rename internal material id to MucfMatId - Remove find MucfMatId function from DTMixMucfData and make it a lambda in the executor
- Fix integral_xs bool - Fwd declare material and particle params - Remove trailing includes
stognini
added
enhancement
23 tasks
Test summary 5 928 files 9 466 suites 18m 56s ⏱️ Results for commit 52f8154. ♻️ This comment has been updated with latest results. |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## develop #2240 +/- ##
===========================================
+ Coverage 86.87% 87.17% +0.29%
===========================================
Files 1331 1334 +3
Lines 42102 42366 +264
Branches 12951 13014 +63
===========================================
+ Hits 36578 36932 +354
+ Misses 4319 4238 -81
+ Partials 1205 1196 -9
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR completes another component of #1508 . It adds the cycle rate data for dd, dt, and tt fusion interactions in
inp::, and correctly constructs the host/device data used by the muCF model.