Replace Core State counter synchronization with host functors or device kernel calls#2242
Draft
LSchwiebert wants to merge 43 commits intoceleritas-project:developfrom
Draft
Replace Core State counter synchronization with host functors or device kernel calls#2242LSchwiebert wants to merge 43 commits intoceleritas-project:developfrom
LSchwiebert wants to merge 43 commits intoceleritas-project:developfrom
Conversation
…ert/celeritas into CoreStateCounters-track
…ert/celeritas into CoreStateCounters-track
…ebert/celeritas into CoreStateCounters-optical
…ebert/celeritas into CoreStateCounters-optical
…ebert/celeritas into CoreStateCounters-kernels
Test summary 5 908 files 9 446 suites 8m 4s ⏱️ Results for commit 4daf06e. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2242 +/- ##
===========================================
- Coverage 86.87% 85.28% -1.60%
===========================================
Files 1331 1299 -32
Lines 42102 40556 -1546
Branches 12951 10554 -2397
===========================================
- Hits 36578 34588 -1990
- Misses 4319 4378 +59
- Partials 1205 1590 +385
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces the synchronized Core State counter getter and setter functions with device kernel calls or host functors. These getter and setter functions were introduced in PR #2177 and #2208, which moved these counters to the device. The objective is to remove synchronization between the host and device when running an event.
Currently, this has code to revise only one synchronization -- the synchronization in the Stepper::operator()(SpanConstPrimary primaries) function -- with a functionally-equivalent executor functor. Once everyone is happy with the solution used here, it will be replicated elsewhere to replace other synchronizations. Just trying to reduce the burden of reviewing similar changes.