Skip to content

Add error checking to vecgeom track view#2245

Open
sethrj wants to merge 15 commits intoceleritas-project:developfrom
sethrj:vg-error-checking
Open

Add error checking to vecgeom track view#2245
sethrj wants to merge 15 commits intoceleritas-project:developfrom
sethrj:vg-error-checking

Conversation

@sethrj
Copy link
Member

@sethrj sethrj commented Feb 7, 2026

This pulls some components out of #2133:

  • Remove special case for starting outside the geometry, which is not compatible with some newer vecgeom
  • Check some device pointers during setup
  • Deletes unused methods in the v1 solids navigator
  • Unifies interface somewhat between the vg versions
  • Fail if starting outside the geometry
  • Fail if next step returns zero distance

@sethrj sethrj requested a review from mrguilima as a code owner February 7, 2026 01:13
@sethrj sethrj added enhancement New feature or request geometry Geometry-related features (geocel) labels Feb 7, 2026
@codecov
Copy link

codecov bot commented Feb 7, 2026

Codecov Report

❌ Patch coverage is 82.25806% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.92%. Comparing base (818ec9c) to head (b84a244).

Files with missing lines Patch % Lines
src/geocel/vg/detail/BVHNavigator.hh 71.42% 8 Missing and 2 partials ⚠️
src/geocel/vg/VecgeomTrackView.hh 96.29% 0 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2245      +/-   ##
===========================================
+ Coverage    86.88%   86.92%   +0.03%     
===========================================
  Files         1331     1331              
  Lines        42123    42120       -3     
  Branches     12961    12964       +3     
===========================================
+ Hits         36600    36611      +11     
+ Misses        4319     4305      -14     
  Partials      1204     1204              
Files with missing lines Coverage Δ
src/geocel/vg/VecgeomData.hh 97.14% <ø> (ø)
src/geocel/vg/VecgeomParams.cc 64.03% <ø> (ø)
src/geocel/vg/VecgeomTrackView.hh 99.27% <96.29%> (+10.22%) ⬆️
src/geocel/vg/detail/BVHNavigator.hh 85.96% <71.42%> (+0.37%) ⬆️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 7, 2026

Test summary

 5 912 files   9 450 suites   17m 53s ⏱️
 2 150 tests  2 120 ✅  28 💤 2 ❌
32 304 runs  32 144 ✅ 158 💤 2 ❌

For more details on these failures, see this check.

Results for commit b84a244.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request geometry Geometry-related features (geocel)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant