Use uppercase enum values for PEP compliance#9
Merged
sethrj merged 1 commit intoceleritas-project:mainfrom Oct 17, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates enum values to use uppercase naming convention for PEP compliance, migrating from snake_case to UPPER_CASE enum members while maintaining backward compatibility through deprecated lowercase aliases.
- Updates all enum definitions to use
StrEnumandauto()for consistent uppercase values - Maintains backward compatibility by providing lowercase aliases for existing enum members
- Updates test files and configuration to use the new uppercase enum values
Reviewed Changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| celerpy/model.py | Converts enums to StrEnum with uppercase values and backward compatibility aliases |
| celerpy/conf/settings.py | Imports LogLevel from model.py and updates default values to uppercase |
| celerpy/visualize.py | Updates enum references to use uppercase values and adds visualization improvements |
| test/test_visualize.py | Updates test code to use uppercase enum values |
| test/test_model.py | Adds test to verify backward compatibility of lowercase enum values |
| pyproject.toml | Removes numpy mypy plugin |
| requirements-dev.txt | Updates development dependencies to newer versions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
17cdbf9 to
c6c3132
Compare
c6c3132 to
b3d33a0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.