Skip to content

Conversation

@vgonkivs
Copy link
Member

@vgonkivs vgonkivs commented Aug 12, 2022

Supplement for #536. Change from this commit is needed to simplify logic inside fraud sync.

Updated to the latest pub sub version + small changes that hasn't yet merged.

Bonus: should fix #899

@vgonkivs vgonkivs added the kind:deps Pull requests that update a dependency file label Aug 12, 2022
@vgonkivs vgonkivs self-assigned this Aug 12, 2022
@renaynay
Copy link
Member

wen #887 😞

@codecov-commenter
Copy link

Codecov Report

Merging #1006 (501a661) into main (6e4e694) will increase coverage by 0.69%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1006      +/-   ##
==========================================
+ Coverage   58.36%   59.05%   +0.69%     
==========================================
  Files         132      133       +1     
  Lines        7947     8041      +94     
==========================================
+ Hits         4638     4749     +111     
+ Misses       2833     2817      -16     
+ Partials      476      475       -1     
Impacted Files Coverage Δ
ipld/get_shares.go 90.90% <0.00%> (-0.93%) ⬇️
ipld/helpers.go 100.00% <0.00%> (ø)
service/share/share.go 81.01% <0.00%> (ø)
ipld/get_namespaced_shares.go 90.37% <0.00%> (ø)
fraud/pb/proof.pb.go 37.80% <0.00%> (+2.14%) ⬆️
core/fetcher.go 54.46% <0.00%> (+2.67%) ⬆️
fraud/bad_encoding.go 67.92% <0.00%> (+2.83%) ⬆️
ipld/get.go 82.60% <0.00%> (+5.46%) ⬆️
header/core/listener.go 60.37% <0.00%> (+7.54%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vgonkivs vgonkivs force-pushed the update_libp2p_fork_version branch from 501a661 to 38c0631 Compare August 12, 2022 13:24
@vgonkivs vgonkivs merged commit cb6f845 into celestiaorg:main Aug 12, 2022
@vgonkivs vgonkivs deleted the update_libp2p_fork_version branch January 9, 2023 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind:deps Pull requests that update a dependency file

Projects

No open projects
Archived in project

Development

Successfully merging this pull request may close these issues.

tests: panic in PubSub

4 participants