feat(shwap): Update availability to work with shwap#3600
Merged
Wondertan merged 4 commits intocelestiaorg:shwapfrom Aug 1, 2024
Merged
feat(shwap): Update availability to work with shwap#3600Wondertan merged 4 commits intocelestiaorg:shwapfrom
Wondertan merged 4 commits intocelestiaorg:shwapfrom
Conversation
walldiss
force-pushed
the
shwap-availability
branch
from
fdbc211 to
2e05c59
Compare
walldiss
requested review from
Wondertan,
cristaloleg,
distractedm1nd,
ramin,
renaynay and
vgonkivs
as code owners
walldiss
force-pushed
the
shwap-availability
branch
from
4528005 to
d6bfea3
Compare
walldiss
force-pushed
the
shwap-availability
branch
from
d6bfea3 to
579ca32
Compare
Wondertan
reviewed
Jul 31, 2024
Member
Wondertan
left a comment
Wondertan
left a comment
There was a problem hiding this comment.
Few comments, LFG, otherwise
share/shwap/p2p/bitswap/getter.go
Outdated
| @@ -183,10 +183,10 @@ func (g *Getter) GetSharesByNamespace( | |||
| } | |||
|
|
|||
| // TODO(@Wondertan): this must use shwap types eventually | |||
Member
There was a problem hiding this comment.
Can remove it as it does that with this PR.
| // short-circuit if the given root is an empty data square, to avoid datastore hit | ||
| // if the data square is empty, we can safely link the header height in the store to an empty EDS. | ||
| if share.DataHash(dah.Hash()).IsEmptyEDS() { | ||
| fa.store.Put(ctx, dah, header.Height(), share.EmptyEDS()) |
Member
There was a problem hiding this comment.
should still check for an error
| // TestShareAvailable_OneFullNode asserts that a full node can ensure | ||
| // data is available (reconstruct data square) while being connected to | ||
| // light nodes only. | ||
| func TestShareAvailable_OneFullNode(t *testing.T) { |
Member
There was a problem hiding this comment.
We should keep those tests but comment instead, so we can quickly rewrite once we get to reconstruction
We discussed that we need them and agreed to keep them on the availability level.
walldiss
force-pushed
the
shwap-availability
branch
from
7d1b850 to
3ae0db2
Compare
Wondertan
approved these changes
Aug 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates Availability and related tests to be aligned with shwap underlying getter
Blocked by #3554