Cephadm support and other minor changes #88
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cephadm prints to STDERR so that cannot be used to detect errors
Also correctly use keyring etc. parameters in the OSD loop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds cephadm support for:
It is implemented following #68 so thanks go to WarriorXK for the original PR.
Unfortunately
cephadmdoesn't run non-root. I do not have time to check how complicated that would be.While at it I added support using other than the default keyring with cephadm which fixes #87.
To make it work on my Python 3 I also needed to make changes similar to #84 in order to avoid errors when handling output from
ceph.Indentation was fixed in
check_ceph_osd. Some files continue to use 4 spaces and others use 2...Added version to
check_ceph_osd_dband also the second call tocephinside the loop will now use ID/keyring/etc. arguments in the same way as the initial call toceph. Also, if critical limit is given with-Cargument it needs to be cast to a float (at least on my Python 3.9).The PR works for me but I have not done extensive testing. Especially I might have missed some error handling/UTF-8 decoding in output processing.
I am sure there could be room to improve so feedback is very welcome.