Skip to content

Fix location of installed header files. #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
szanni wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix location of installed header files. #1

szanni wants to merge 1 commit into from

Conversation

@szanni
Copy link

@szanni szanni commented Nov 24, 2014

This fixes the issue of missing includes when using
the system-wide header jerasure.h

@szanni
Fix location of installed header files.
837c76c 
This fixes the issue of missing includes when using
the header <jerasure.h>.
dalgaaf added a commit that referenced this pull request Dec 14, 2014
@dalgaaf
jerasure.c: fix memory leak in error case
6d8fbc8 
Check matrix for NULL before call talloc().

CID 1093213 (#1 of 1): Resource leak (RESOURCE_LEAK)
 4. leaked_storage: Variable "bitmatrix" going out of scope
 leaks the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
dalgaaf added a commit that referenced this pull request Dec 14, 2014
@dalgaaf
jerasure.c: free memory before return in error case
b14af86 
Fix for Coverity issue from Ceph project:

CID 1093211 (#1 of 1): Resource leak (RESOURCE_LEAK)
 20. leaked_storage: Variable "ind_to_row" going out of scope leaks
 the storage it points to.

CID 1093212 (#1 of 1): Resource leak (RESOURCE_LEAK)
 20. leaked_storage: Variable "row_ids" going out of scope leaks the
 storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
@kmgreen2
Copy link
Contributor

kmgreen2 commented Dec 16, 2014

Is there a bigger issue here than doing housecleaning? I ask because, introducing this change could result in a regression for existing users, since it relocates a bunch of the header files.

@szanni
Copy link
Author

szanni commented Dec 18, 2014

As it stands right now jerasure.h is installed in include.
jerasure.h however includes #include "galois.h" which is installed in include/jerasure/galois.h.
This is actually a bug. I'm actually surprised that this has never came up in production.
This commit fixes the issue by installing galois.h and related files in include. The other possibility would be to change the #include and rearrange the files in the source.

@pyrovski
Copy link

pyrovski commented Dec 12, 2015

I agree with szanni; please either fix the includes or add something to the README warning that users will have to specifically fix this issue in their makefiles.

ghost pushed a commit that referenced this pull request Apr 10, 2017
@dalgaaf
jerasure.c: fix memory leak in error case
fa1ea71 
Check matrix for NULL before call talloc().

CID 1093213 (#1 of 1): Resource leak (RESOURCE_LEAK)
 4. leaked_storage: Variable "bitmatrix" going out of scope
 leaks the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
(cherry picked from commit 6d8fbc8)
ghost pushed a commit that referenced this pull request Apr 10, 2017
@dalgaaf
jerasure.c: fix memory leak in error case
f551063 
Check matrix for NULL before call talloc().

CID 1093213 (#1 of 1): Resource leak (RESOURCE_LEAK)
 4. leaked_storage: Variable "bitmatrix" going out of scope
 leaks the storage it points to.

Signed-off-by: Danny Al-Gaaf <danny.al-gaaf@bisect.de>
(cherry picked from commit 6d8fbc8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@szanni @kmgreen2 @pyrovski