Fix git fetch leaving lock files behind with GitCmdObjectDB #48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
You may face that the repo object leaves lock files behind after fetch, so we need to clean them up with a forced object delete Ref: gitpython-developers/GitPython#718 (comment) We suspect this is due to git cat-file calls in fetch implementation together with using GitCmdObjectDB as the object database Ref: https://gitpython.readthedocs.io/en/stable/tutorial.html#gitcmdobjectdb Using GitDB seems to fix the issue but we keep using GitCmdObjectDB for consistency
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You may face that the repo object leaves lock files behind after fetch, so we need to clean them up with a forced object delete
Ref: gitpython-developers/GitPython#718 (comment)
We suspect this is due to git cat-file calls in fetch implementation together with using GitCmdObjectDB as the object database
Ref: https://gitpython.readthedocs.io/en/stable/tutorial.html#gitcmdobjectdb
Using GitDB seems to fix the issue but we keep using GitCmdObjectDB for consistency