Skip to content

Comments

Temporarily switch to go-licenses fork#289

Merged
cert-manager-prow[bot] merged 1 commit intomainfrom
temporary_licenses_fork
May 5, 2025
Merged

Temporarily switch to go-licenses fork#289
cert-manager-prow[bot] merged 1 commit intomainfrom
temporary_licenses_fork

Conversation

@inteon
Copy link
Member

@inteon inteon commented May 5, 2025

Temporarily switch to fork that contains these changes: google/go-licenses#327

Should fix cert-manager/cert-manager#6622

Signed-off-by: Tim Ramlot <42113979+inteon@users.noreply.github.com>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 5, 2025
@inteon inteon force-pushed the temporary_licenses_fork branch from 7a5549b to 5423c66 Compare May 5, 2025 13:05
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@cert-manager-prow cert-manager-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 5, 2025
@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 5, 2025
@cert-manager-prow cert-manager-prow bot merged commit 64ae59d into main May 5, 2025
4 checks passed
@wallrj wallrj deleted the temporary_licenses_fork branch May 6, 2025 08:37
@wallrj
Copy link
Member

wallrj commented Jun 3, 2025

It's still really flaky.

Here's an example:

...
W0603 19:35:38.130919    3172 report.go:128] Error discovering license URL: getting file URL in library github.com/blang/semver/v4: source.ModuleInfo(ctx, "github.com/blang/semver/v4", "v4.0.0"): doURL(ctx, client, "HEAD", "https://github.com/blang/semver/raw/v4.0.0/v4/go.mod"): Head "https://github.com/blang/semver/raw/v4.0.0/v4/go.mod": context deadline exceeded
W0603 19:35:38.409510    3172 report.go:128] Error discovering license URL: getting file URL in library sigs.k8s.io/structured-merge-diff/v4: source.ModuleInfo(ctx, "sigs.k8s.io/structured-merge-diff/v4", "v4.5.0"): doURL(ctx, client, "HEAD", "https://github.com/kubernetes-sigs/structured-merge-diff/raw/v4.5.0/v4/go.mod"): Head "https://github.com/kubernetes-sigs/structured-merge-diff/raw/v4.5.0/v4/go.mod": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
W0603 19:35:38.410496    3172 report.go:128] Error discovering license URL: getting file URL in library k8s.io/klog/v2: source.ModuleInfo(ctx, "k8s.io/klog/v2", "v2.130.1"): doURL(ctx, client, "HEAD", "https://github.com/kubernetes/klog/raw/v2.130.1/v2/go.mod"): Head "https://github.com/kubernetes/klog/raw/v2.130.1/v2/go.mod": net/http: request canceled (Client.Timeout exceeded while awaiting headers)
make[2]: Leaving directory '/tmp/verify.sh.Hqt41uV9'
make[1]: Leaving directory '/tmp/verify.sh.Hqt41uV9'
diff '--exclude=.git' '--exclude=_bin' --new-file --unified --show-c-function --recursive /home/prow/go/src/github.com/cert-manager/cert-manager/test/e2e/LICENSES /tmp/verify.sh.Hqt41uV9/test/e2e/LICENSES
--- /home/prow/go/src/github.com/cert-manager/cert-manager/test/e2e/LICENSES	2025-06-03 19:33:51.020116459 +0000
+++ /tmp/verify.sh.Hqt41uV9/test/e2e/LICENSES	2025-06-03 19:35:38.410258635 +0000
@@ -1,16 +1,16 @@
 github.com/Azure/go-ntlmssp,https://github.com/Azure/go-ntlmssp/blob/754e69321358/LICENSE,MIT
 github.com/beorn7/perks/quantile,https://github.com/beorn7/perks/blob/v1.0.1/LICENSE,MIT
-github.com/blang/semver/v4,https://github.com/blang/semver/blob/v4.0.0/v4/LICENSE,MIT
+github.com/blang/semver/v4,Unknown,MIT
...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make update-licenses is non-deterministic.

3 participants