-
Notifications
You must be signed in to change notification settings - Fork 32
feat(cert-manager): adding 1.35 test job #1132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Hemant Joshi <mail@hjoshi.me>
erikgb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hjoshi123! The diff looks good to me, but shouldn't the 1.35 job be defined after the 1.34 job?
/approve
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: erikgb The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Oh I am not sure what happened there. It's basically prowgen which edited the file. Ideally that does make sense that it comes after. |
Maybe set it as the default? That makes sense anyway, and I am pretty sure it will work. |
I thought maybe we should test if the job works before setting as default right? |
|
@erikgb Maybe we can merge this and test stuff out and then make it the default? |
Adding 1.35 job to test if things work before making it primary version