Skip to content

Conversation

@hjoshi123
Copy link
Contributor

Adding 1.35 job to test if things work before making it primary version

Signed-off-by: Hemant Joshi <mail@hjoshi.me>
@cert-manager-prow cert-manager-prow bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Dec 24, 2025
Copy link
Member

@erikgb erikgb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hjoshi123! The diff looks good to me, but shouldn't the 1.35 job be defined after the 1.34 job?

/approve

@cert-manager-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: erikgb

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 25, 2025
@hjoshi123
Copy link
Contributor Author

hjoshi123 commented Dec 25, 2025

Thanks @hjoshi123! The diff looks good to me, but shouldn't the 1.35 job be defined after the 1.34 job?

/approve

Oh I am not sure what happened there. It's basically prowgen which edited the file. Ideally that does make sense that it comes after.

@erikgb
Copy link
Member

erikgb commented Dec 25, 2025

Thanks @hjoshi123! The diff looks good to me, but shouldn't the 1.35 job be defined after the 1.34 job?
/approve

Oh I am not sure what happened there. It's basically prowgen which edited the file. Ideally that does make sense that it comes after.

Maybe set it as the default? That makes sense anyway, and I am pretty sure it will work.

@hjoshi123
Copy link
Contributor Author

Thanks @hjoshi123! The diff looks good to me, but shouldn't the 1.35 job be defined after the 1.34 job?
/approve

Oh I am not sure what happened there. It's basically prowgen which edited the file. Ideally that does make sense that it comes after.

Maybe set it as the default? That makes sense anyway, and I am pretty sure it will work.

I thought maybe we should test if the job works before setting as default right?

@hjoshi123
Copy link
Contributor Author

@erikgb Maybe we can merge this and test stuff out and then make it the default?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants