Refactor encoding and decoding to use MaybeUninit for improved safety and flexibility#6
Merged
cfcosta merged 1 commit intocfcosta:mainfrom Nov 8, 2025
Merged
Conversation
…ty and flexibility.
Owner
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
This PR refactors the crate to use
MaybeUninitproperly, fixing safety violations while improving flexibility and performance.Changes
1. Fixed Safety Violations
The original
decodefunction violatedVec::set_len()safety contract:Before (Line 188):
Problem:
Vec::set_len()requires that "all elements in0..new_lenmust be initialized." This code violated that contract by marking memory as initialized before actually writing to it.After:
Now
set_len()is only called after bytes are actually initialized, fully respecting safety invariants.2. Introduced
BufTrait for FlexibilityAdded a
Buftrait that abstracts over buffer types:Benefits:
[fixed_str](https://docs.rs/fixed_str/latest/fixed_str/)for efficient fixed-size stringsBuffor custom buffer typesExample with
fixed_str(my use case: 32-byte hash Display implementations):3. Performance Improvements
Encoding now outperforms
faster-hex:~29% faster throughput on encoding operations.