Skip to content

Conversation

@btriller
Copy link
Contributor

Get rid of shells and other command and use Python itself for version check.
Get major/minor via tuple for compatibility with very ancient Python versions (sys.version_info.major etc introduced in 2.7) [1].

[1] https://docs.python.org/2/library/sys.html#sys.version_info

Get rid of shells and other command and use Python itself for version
check.
Get major/minor via tuple for compatibility with very ancient Python
versions (sys.version_info.major etc introduced in 2.7) [1].

[1] https://docs.python.org/2/library/sys.html#sys.version_info
@cf-bottom
Copy link

Thank you for submitting a pull request! Maybe @craigcomstock can review this?

Copy link
Contributor

@craigcomstock craigcomstock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable. Thanks for the contribution! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants