Add FLIC dataset #495
Add FLIC dataset #495
Conversation
|
|
||
| ] | ||
|
|
||
| flic_joint_label_names = [ |
| the FLIC dataset. | ||
| return_torsobox (bool): If :obj:`True`, this returns a bounding box | ||
| around the torso. The default value is :obj:`False`. | ||
| skip_bad (bool): If :obj:`True`, the data which have :obj:`isbad = 1` |
There was a problem hiding this comment.
How about use_bad and use_unchecked?
This style is consistent with the other datasets.
https://github.com/chainer/chainercv/blob/master/chainercv/datasets/voc/voc_bbox_dataset.py#L70
| 'isbad', | ||
| 'isunchecked', | ||
| ] | ||
| labels = loadmat(os.path.join(data_dir, 'FLIC-full', 'examples.mat')) |
There was a problem hiding this comment.
How about annos?
labels is overused in ChainerCV already.
There was a problem hiding this comment.
Similarly, label_key -> anno_key.
| Args: | ||
| data_dir (string): Path to the root of the training data. If this is | ||
| :obj:`auto`, this class will automatically download data for you | ||
| under :obj:`$CHAINER_DATASET_ROOT/pfnet/chainercv/cub`. |
| urls = [ | ||
| 'http://vision.grasp.upenn.edu/video/FLIC-full.zip', | ||
|
|
||
| 'http://cims.nyu.edu/~tompson/data/tr_plus_indices.mat', |
There was a problem hiding this comment.
Can you delete this, or comment what this is?
| data_root, | ||
| ext) | ||
|
|
||
| return data_root |
There was a problem hiding this comment.
Can you make this function return
$CHAINER_ROOT/pfnet/chainercv/flic/FLIC-full ?
This is more consistent with other download functions.
|
Nice PR. |
|
@yuyu2172 Thanks for the review. I've fixed the points. |
|
Not sure what's blocking this PR, but just resolved conflicts for now. |
|
Please wait until #787 is merged |
3 participants
This PR adds a dataset class for human pose dataset FLIC. It follows the convention of keypoint dataset like
CUBKeypointDataset.