package-type-check: normalize paths to always have a leading "/" symbol #262
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aborrero
force-pushed
the
arturo-306-package-type-check
branch
from
b2b05ff to
92c8458
Compare
aborrero
force-pushed
the
arturo-306-package-type-check
branch
from
92c8458 to
96c61c1
Compare
The code was mixing logic with leading "/" symbol for file paths. Update the logic to always use the symbol, as that's more natural behavior. In order to don't break current test cases in packages, for example for doc packages declaring a path-prefix without the leading "/" symbol, the symbol will be added by this new code. At the same time, for the doc package checker in particular, a new check for the /doc/ subdirectory is introduced, which will check for things like /usr/share/doc. While at it, some basic go unit tests are introduced. Signed-off-by: Arturo Borrero Gonzalez <arturo.borrero@chainguard.dev>
aborrero
force-pushed
the
arturo-306-package-type-check
branch
from
96c61c1 to
dcf9174
Compare
debasishbsws
approved these changes
Jan 15, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code was mixing logic with leading "/" symbol for file paths. Update the logic to always use the symbol, as that's more natural behavior.
In order to don't break current test cases in packages, for example for doc packages declaring a path-prefix without the leading "/" symbol, the symbol will be added by this new code.
At the same time, for the doc package checker in particular, a new check for the /doc/ subdirectory is introduced, which will check for things like /usr/share/doc.
While at it, some basic go unit tests are introduced.