This repository was archived by the owner on Apr 23, 2024. It is now read-only.
Open
Conversation
Owner
|
Sorry for the delayed response - I was on travel. I remember we had a chat about this but its been a while and I forgot some of it, sorry if I ask the same questions again.
You can rename the database columns from r4..r8 to anything you want. Don't worry about the aesthetics of the pull request. I can resolve the conflicts and merge. I'll keep going over the code whenever I find time. And thanks a lot for working on this! |
Author
Also I probably should have refactored the names r4 through r8, but I'm sort of already accustomed to them so.... shrugs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this code, ratings should be operational, though there will be no way for any users to see their ratings (that is yet to be implemented). Currently, ratings are being recalculated from the "beginning of time" (April 23rd), but it's only a slight time waste at the moment, and you can probably fix that quite easily (I didn't fix it because I don't know how you want the data stored). Also, sorry for the ugly pull request, but I'm not a git expert yet, and it's not letting me pull your master branch so easily.