12_SimpleGeometryShader_VK - fix of buffer overrun.#23
Open
pbialeck wants to merge 1 commit intochaoticbob:masterfrom
Open
12_SimpleGeometryShader_VK - fix of buffer overrun.#23pbialeck wants to merge 1 commit intochaoticbob:masterfrom
pbialeck wants to merge 1 commit intochaoticbob:masterfrom
Conversation
pbialeck
commented
May 10, 2022
| tr_create_uniform_buffer(m_renderer, 16 * sizeof(float), true, &m_uniform_buffer); | ||
|
|
||
| m_desc_set->descriptors[0].uniform_buffers[0] = m_uniform_buffer; | ||
| m_desc_set->descriptors[1].textures[0] = m_texture; |
Author
There was a problem hiding this comment.
This code caused buffer overrun because std::vector descriptors in line 216 has one element and m_desc_set->descriptors is allocated with one element too.
Removed buffer overrun code and creation of m_texture and m_sampler.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.