Skip to content

feat(table): v2 table bubble #772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bashbunni wants to merge 27 commits into
base: v2-exp
Choose a base branch
from
Open

feat(table): v2 table bubble #772

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
27 commits
Select commit Hold shift + click to select a range
a0c4366
feat(table): use lipgloss table to render
bashbunni Apr 1, 2025
738180e
feat(table): respect border settings
bashbunni Apr 2, 2025
a687f2f
refactor: tidy + update godoc
bashbunni Apr 3, 2025
ae7fb0d
feat(table): use padding for default cell styles
bashbunni Apr 3, 2025
5191362
test(table): add style and border tests
bashbunni Apr 3, 2025
242df04
feat(table): create table bubble from a lip gloss table
bashbunni Apr 4, 2025
9489b33
docs(table): more godoc updates
bashbunni Apr 4, 2025
55b5472
test(table): add TestOverwriteStylesFromLipgloss test
bashbunni Apr 4, 2025
1360eaf
fix(test): use valid naming for golden file
bashbunni Apr 4, 2025
46da4a8
feat(table): remove redundant SetFocused function
bashbunni Apr 4, 2025
a291578
feat(table): remove FromValues feature
bashbunni Apr 4, 2025
7df8953
chore: tidy comments
bashbunni Apr 4, 2025
57b6175
Merge branch 'v2-exp' into v2-table
andreynering May 21, 2025
41f23fe
test: review tests after merge. some yet to be addressed
andreynering May 21, 2025
8ee7e4b
refactor(table): rename tests to match a convention
andreynering May 21, 2025
8acc3de
chore(go.mod): pin lipgloss from branch `v2-table-fixes`
andreynering May 28, 2025
78e9bc4
test: re-enable tests and record golden files after fixes on lipgloss
andreynering May 28, 2025
dcb67fb
chore: fix linting issues
andreynering May 29, 2025
82a5f27
chore: update lipgloss@v2-table-fixes
andreynering May 29, 2025
2110223
refactor(table): get data from lipgloss instead of storing it separately
andreynering May 29, 2025
fe39af2
refactor(table): rename `OverwriteStylesFromLipgloss` to `LipglossTable`
andreynering May 29, 2025
aa84c7f
refactor(table): remove uneeded extra args from `NewFromTemplate`
andreynering May 29, 2025
f0f84c8
refactor(table): remove inner border attrs, get directly from lipgloss
andreynering May 30, 2025
bf386db
fix(table): fix cursor and offset handling
andreynering May 30, 2025
e7748f0
fix(table): add fixes to `pageup`/`pagedown`
andreynering May 30, 2025
3e51750
chore(go.mod): update lipgloss from `v2-exp`
andreynering Jun 3, 2025
8b46d0b
Merge branch 'v2-exp' into v2-table
andreynering Jun 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion Taskfile.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# https://taskfile.dev

version: '3'
version: "3"

tasks:
lint:
Expand All @@ -12,3 +12,8 @@ tasks:
desc: Run tests
cmds:
- go test ./... {{.CLI_ARGS}}

test:table:
desc: Run tests with table test
cmds:
- go test ./table {{.CLI_ARGS}}
6 changes: 3 additions & 3 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ require (
github.com/atotto/clipboard v0.1.4
github.com/charmbracelet/bubbletea/v2 v2.0.0-beta.1
github.com/charmbracelet/harmonica v0.2.0
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1.0.20250603140710-946081c6f1a5
github.com/charmbracelet/x/ansi v0.8.0
github.com/charmbracelet/x/exp/golden v0.0.0-20250207160936-21c02780d27a
github.com/dustin/go-humanize v1.0.1
Expand All @@ -19,7 +19,7 @@ require (

require (
github.com/aymanbagabas/go-udiff v0.2.0 // indirect
github.com/charmbracelet/colorprofile v0.3.0 // indirect
github.com/charmbracelet/colorprofile v0.3.1 // indirect
github.com/charmbracelet/x/cellbuf v0.0.13 // indirect
github.com/charmbracelet/x/input v0.3.4 // indirect
github.com/charmbracelet/x/term v0.2.1 // indirect
Expand All @@ -28,5 +28,5 @@ require (
github.com/muesli/cancelreader v0.2.2 // indirect
github.com/xo/terminfo v0.0.0-20220910002029-abceb7e1c41e // indirect
golang.org/x/sync v0.12.0 // indirect
golang.org/x/sys v0.31.0 // indirect
golang.org/x/sys v0.32.0 // indirect
)
12 changes: 6 additions & 6 deletions go.sum
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ github.com/aymanbagabas/go-udiff v0.2.0 h1:TK0fH4MteXUDspT88n8CKzvK0X9O2xu9yQjWp
github.com/aymanbagabas/go-udiff v0.2.0/go.mod h1:RE4Ex0qsGkTAJoQdQQCA0uG+nAzJO/pI/QwceO5fgrA=
github.com/charmbracelet/bubbletea/v2 v2.0.0-beta.1 h1:RvpXiXuPAuaKCHPCsE/lK5+zztnNDTSCa0CpeeIKdDU=
github.com/charmbracelet/bubbletea/v2 v2.0.0-beta.1/go.mod h1:qbcZLI5z8R49v9xBdU5V5Dh5D2uccx8wSwBqxQyErqc=
github.com/charmbracelet/colorprofile v0.3.0 h1:KtLh9uuu1RCt+Hml4s6Hz+kB1PfV3wi++1h5ia65yKQ=
github.com/charmbracelet/colorprofile v0.3.0/go.mod h1:oHJ340RS2nmG1zRGPmhJKJ/jf4FPNNk0P39/wBPA1G0=
github.com/charmbracelet/colorprofile v0.3.1 h1:k8dTHMd7fgw4bnFd7jXTLZrSU/CQrKnL3m+AxCzDz40=
github.com/charmbracelet/colorprofile v0.3.1/go.mod h1:/GkGusxNs8VB/RSOh3fu0TJmQ4ICMMPApIIVn0KszZ0=
github.com/charmbracelet/harmonica v0.2.0 h1:8NxJWRWg/bzKqqEaaeFNipOu77YR5t8aSwG4pgaUBiQ=
github.com/charmbracelet/harmonica v0.2.0/go.mod h1:KSri/1RMQOZLbw7AHqgcBycp8pgJnQMYYT8QZRqZ1Ao=
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1 h1:D9AJJuYTN5pvz6mpIGO1ijLKpfTYSHOtKGgwoTQ4Gog=
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1/go.mod h1:tRlx/Hu0lo/j9viunCN2H+Ze6JrmdjQlXUQvvArgaOc=
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1.0.20250603140710-946081c6f1a5 h1:vq3WdrGHQ6T0ZBYdRhn2toyQXDD+uneu3IdcMni7J5g=
github.com/charmbracelet/lipgloss/v2 v2.0.0-beta.1.0.20250603140710-946081c6f1a5/go.mod h1:EJWvaCrhOhNGVZMvcjc0yVryl4qqpMs8tz0r9WyEkdQ=
github.com/charmbracelet/x/ansi v0.8.0 h1:9GTq3xq9caJW8ZrBTe0LIe2fvfLR/bYXKTx2llXn7xE=
github.com/charmbracelet/x/ansi v0.8.0/go.mod h1:wdYl/ONOLHLIVmQaxbIYEC/cRKOQyjTkowiI4blgS9Q=
github.com/charmbracelet/x/cellbuf v0.0.13 h1:/KBBKHuVRbq1lYx5BzEHBAFBP8VcQzJejZ/IA3iR28k=
Expand Down Expand Up @@ -45,5 +45,5 @@ golang.org/x/exp v0.0.0-20231006140011-7918f672742d h1:jtJma62tbqLibJ5sFQz8bKtEM
golang.org/x/exp v0.0.0-20231006140011-7918f672742d/go.mod h1:ldy0pHrwJyGW56pPQzzkH36rKxoZW1tw7ZJpeKx+hdo=
golang.org/x/sync v0.12.0 h1:MHc5BpPuC30uJk597Ri8TV3CNZcTLu6B6z4lJy+g6Jw=
golang.org/x/sync v0.12.0/go.mod h1:1dzgHSNfp02xaA81J2MS99Qcpr2w7fw1gpm99rleRqA=
golang.org/x/sys v0.31.0 h1:ioabZlmFYtWhL+TRYpcnNlLwhyxaM9kWTDEmfnprqik=
golang.org/x/sys v0.31.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
golang.org/x/sys v0.32.0 h1:s77OFDvIQeibCmezSnk/q6iAfkdiQaJi4VzroCFrN20=
golang.org/x/sys v0.32.0/go.mod h1:BJP2sWEmIv4KK5OTEluFJCKSidICx8ciO85XgH3Ak8k=
Loading
Loading