Skip to content

fix(viewport): prevent panic when height is negative or zero #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
semihbkgr wants to merge 1 commit into
base: master
Choose a base branch
from
+35 −0
Open

fix(viewport): prevent panic when height is negative or zero #880

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions viewport/viewport.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,6 +147,9 @@ func (m Model) visibleLines() (lines []string) {
if len(m.lines) > 0 {
top := max(0, m.YOffset)
bottom := clamp(m.YOffset+h, top, len(m.lines))
if top >= bottom {
return nil
}
lines = m.lines[top:bottom]
}

Expand Down
32 changes: 32 additions & 0 deletions viewport/viewport_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,6 +201,38 @@ func TestVisibleLines(t *testing.T) {
}
})

t.Run("negative height should not panic", func(t *testing.T) {
t.Parallel()

m := New(10, 10)
m.SetContent(strings.Join(defaultList, "\n"))
m.YOffset = 5
m.Height = -4

// This should not panic
list := m.visibleLines()

if list != nil {
t.Errorf("list should be nil with negative height, got %d items", len(list))
}
})

t.Run("zero height should not panic", func(t *testing.T) {
t.Parallel()

m := New(10, 10)
m.SetContent(strings.Join(defaultList, "\n"))
m.YOffset = 5
m.Height = 0

// This should not panic
list := m.visibleLines()

if list != nil {
t.Errorf("list should be nil with zero height, got %d items", len(list))
}
})

t.Run("empty list: with indent", func(t *testing.T) {
t.Parallel()

Expand Down