Add new subscriptions list, connect and disconnect #121
+93
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR adds support for connecting and disconnecting customer subscriptions through the Metrics API, while deprecating the old Customer API methods for these operations.
- Introduces new
connectSubscriptionsanddisconnectSubscriptionsmethods underMetrics.Customer - Deprecates existing
Customer.connectSubscriptionsandCustomer.disconnectSubscriptionsmethods with deprecation warnings - Updates documentation to reflect the new recommended API usage
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| lib/chartmogul/metrics/customer.js | Adds new connectSubscriptions and disconnectSubscriptions methods to Metrics.Customer |
| lib/chartmogul/customer.js | Wraps existing methods with deprecation warnings directing users to the new Metrics API |
| test/chartmogul/metrics/index.js | Adds test cases for the new connect and disconnect subscription methods |
| README.md | Updates documentation with deprecation notices and new Metrics API usage examples |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Open
16 tasks
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wscourge
force-pushed
the
wiktor/ome-417-add-support-for-subscription-connections-via
branch
from
631c7af to
c4bbc46
Compare
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecated Methods (with console warnings):
Customer.connectSubscriptions()- logs deprecation warning to consoleCustomer.disconnectSubscriptions()- logs deprecation warning to consoleNew Methods in
Metrics.Customer:connectSubscriptions(config, dataSourceUuid, customerUuid, data, callback)disconnectSubscriptions(config, dataSourceUuid, customerUuid, data, callback)