chore: [sc-71013] Drop future lib dependency #118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pkopac
reviewed
Sep 1, 2025
Contributor
There was a problem hiding this comment.
This might be possibly a breaking change due to the futures being part of the API of the SDK, ie. chartmogul.Ping.ping(config).get(). You'll need to have a look how the behavior changes and whether we can make it backwards compatible somehow (different library?, mock methods?) or whether we need to issue a major version.
Otherwise scripts would just get randomly broken upon upgrade 👎
pkopac
approved these changes
Sep 1, 2025
Contributor
pkopac
left a comment
pkopac
left a comment
There was a problem hiding this comment.
Never mind me, I thought you were removing promise 🤦
swember
requested review from
a team,
anawolak and
tudorpavel
and removed request for
a team
ya-petrov-evgeniy
approved these changes
Sep 2, 2025
swember
deleted the
dmitriydavydov/sc-71013/drop-future-lib-dependency-from-python-lib
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to Future library vulnerability issue we need to stop using it.