-
Notifications
You must be signed in to change notification settings - Fork 14
Suupport data editing for customer invoices #175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ta-editing-more-resources
This reverts commit 29ff1dc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for data editing of customer invoices through the handle_as_user_edit query parameter. The main changes enable both creating and updating customer invoices with this parameter, which can be passed either during object initialization or as a method argument.
Key Changes:
- Added
handle_as_user_editas a writeable query parameter for CustomerInvoices - Implemented custom
create!andupdate!methods that properly handle query parameters - Enhanced query parameter extraction logic to support both nested and top-level parameters
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| spec/chartmogul/customer_invoices_spec.rb | Added comprehensive test coverage for handle_as_user_edit parameter in both create and update operations |
| lib/chartmogul/customer_invoices.rb | Implemented create! and update! methods with query parameter support and added handle_as_user_edit as writeable query param |
| lib/chartmogul/api_resource.rb | Enhanced query parameter extraction to handle both nested (resource_key) and top-level parameters |
Comments suppressed due to low confidence (1)
lib/chartmogul/customer_invoices.rb:1
- The
create!methods override the includedAPI::Actions::Createfunctionality but the old include statement was removed. This creates potential confusion about which create implementation is being used. Consider adding a comment explaining why a custom implementation is needed instead of using the standardAPI::Actions::Createmodule.
# frozen_string_literal: true
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This reverts commit d5e7c39.
Uh oh!
There was an error while loading. Please reload this page.