test: Synchronization of new transport as primary between devices #7638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reproduces the bug when a new transport doesn't become primary on the 2nd device because I/O isn't restarted when a new transport is added from a sync message, so INBOX from the new transport isn't fetched.
iequidoo
commented
Dec 21, 2025
| .await?; | ||
|
|
||
| context.emit_event(EventType::TransportsModified); | ||
| // context.scheduler.restart(context).await; |
Collaborator
Author
There was a problem hiding this comment.
I couldn't fix the bug quickly because this doesn't compile with error: future cannot be sent between threads safely [...].
Another problem is that we should fetch all existing messages from the new transport, but Config::FetchedExistingMsgs is already 1 at this moment. Otherwise the fix won't be reliable.
Collaborator
There was a problem hiding this comment.
FetchedExistingMsgs does not actually fetch messages. fetch_existing_msgs just looks for existing email addresses in unencrypted headers and adds them to contacts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reproduces the bug when a new transport doesn't become primary on the 2nd device because I/O isn't restarted when a new transport is added from a sync message, so INBOX from the new transport isn't fetched.