Skip to content

Conversation

@le-cong
Copy link
Contributor

@le-cong le-cong commented Jul 19, 2024

@le-cong le-cong added the MINOR label Jul 19, 2024
@le-cong le-cong self-assigned this Jul 19, 2024
@le-cong le-cong changed the title auto-fix to replace fixture usage with native fetch api auto-fix the usage of fixture.api with native fetch Jul 19, 2024
@le-cong le-cong changed the title agent/fetch migration agent Nov 20, 2024
@le-cong le-cong removed the request for review from carlansley November 20, 2024 19:27
@le-cong le-cong marked this pull request as ready for review November 20, 2024 19:43
@github-actions
Copy link

Coverage after merging no-fixture into main will be

84.94%▴ +1.57%

Coverage Report
FileStmtsBranchesFuncsLinesUncovered Lines
src
   file-path-comment.ts100%100%100%100%
   get-documentation-url.ts100%100%100%100%
   index.ts0%0%0%0%1, 1, 10, 100–109, 11, 110–119, 12, 120–129, 13, 130–139, 14, 140–149, 15, 150–159, 16, 160–169, 17, 170–179, 18, 180–189, 19, 190–199, 2, 20, 200–209, 21, 210–219, 22, 220–229, 23, 230–239, 24, 240–249, 25, 250–259, 26, 260–269, 27, 270–279, 28, 280–282, 29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–99
   invalid-json-stringify.ts100%100%100%100%
   no-card-numbers.ts95.11%89.29%100%96.03%134–139, 144–146
   no-duplicated-imports.ts100%100%100%100%
   no-legacy-service-typing.ts100%100%100%100%
   no-promise-instance-method.ts100%100%100%100%
   no-random-v4-uuid.ts100%100%100%100%
   no-serve-runtime.ts100%100%100%100%
   no-side-effects.ts99.31%96.15%100%100%89
   no-test-import.ts100%100%100%100%
   no-uuid.ts95.16%85.71%100%96.23%100–101, 89–91, 99
   no-wallaby-comment.ts97.50%85%100%100%43–44, 58
   object-literal-response.ts100%100%100%100%
   regular-expression-comment.ts95.51%89.47%100%97.06%35–37, 54
   require-assert-predicate-rejects-throws.ts100%100%100%100%
   require-fixed-services-import.ts100%100%100%100%
   require-resolve-full-response.ts83.69%78.33%100%84.72%105–107, 109–111, 113–115, 122–124, 127, 129, 129–131, 147–149, 199–210, 46, 65, 65–67, 81–83, 94–99
   require-strict-assert.ts98.40%92%100%100%44–45
   require-type-out-of-type-only-imports.ts100%100%100%100%
   tester.test.ts100%100%100%100%
   ts-tester.test.ts100%100%100%100%
src/agent
   add-assert-import.ts100%100%100%100%
   add-base-path-const.ts96.88%91.67%100%97.53%39–41
   add-base-path-import.ts100%100%100%100%
   add-url-domain.ts82.76%75%100%82.89%43–45, 59–70
   agent-test-wiring.ts94.46%94.44%93.75%94.51%204–208, 216, 256–267
   fetch-response-body-json.ts93.67%92.31%100%93.81%100, 121–132, 93, 99
   fetch-response-header-getter.ts83.96%88.24%100%82.43%100, 131–142, 70–72, 81–92, 98–99
   fetch-response-status.ts82.20%73.33%100%83%44–46, 49–51, 68–70, 83–94
   fetch-then.ts76.71%53.13%100%78.49%100–138, 218–221, 249, 251–259, 275, 282, 286, 34, 341–349, 35, 350–352, 36, 57–67, 81, 88–90, 94–99
   fetch.ts71.88%89.47%83.33%66.20%21–40, 43–45, 48–50
   file.ts100%100%100%100%
   fix-function-call-arguments.ts90.91%82.14%100%92%100–103, 125–127, 151, 183–194, 66
   no-expect-assertion.ts89.99%81.56%87.50%92.11%114–116, 131, 171–173, 180, 244, 260, 262, 270, 282–285, 324–326, 337–339, 370, 377, 381, 401, 431, 442, 442, 445–447, 458, 461, 464–466, 518–525, 531–538, 553–564, 85–87, 91–93
   no-fixture.ts95.28%97.78%100%94.58%186–197
   no-mapped-response.ts74.49%66.67%100%73.81%42, 45–56, 67–78
   no-service-wrapper.ts80.50%78.57%100%80.50%100–102, 108–110, 112–114, 116–118, 125–127, 130, 132, 132–134, 150–152, 173–179, 190–196, 224–235, 65, 65–66, 68, 68–70, 84–86, 97–99
   no-status-code.ts84.62%83.33%100%84.06%52–63
   no-unused-function-argument.ts89.92%94.12%100%88.78%81–92
   no-unused-imports.ts90.63%95%100%89.32%86–97
   no-unused-service-variable.ts86.24%83.33%100%86.02%59–61, 76–87
   response-reference.ts93.58%78.79%100%96.73%117, 136–138, 147–150, 71–72, 85–86
   supertest-then.ts70.99%48.15%100%73.04%100–121, 161–162, 164–167, 193, 200, 204, 213–224, 30–32, 48–50, 64, 71–73, 77–99
   url.ts100%100%100%100%
src/library
   format.ts95.65%50%100%100%19
   tree.ts0%0%0%0%1, 1, 10–19, 2, 20–29, 3, 30–39, 4, 40–49, 5, 50–59, 6, 60–69, 7, 70–79, 8, 80–89, 9, 90–97
   ts-tree.ts83.22%76.47%87.50%85.05%100–107, 27–29, 29–30, 33, 33–35, 35–37, 61–63, 99
   variable.ts100%100%100%100%

@github-actions
Copy link

Beta Published - Install Command: npm install @checkdigit/eslint-plugin@7.6.0-PR.75-a611

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add rules for auto conversion toward native fetch api

2 participants